hubble/peer: fix buf.Pop() crash issue #12257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While waiting for b.mu.Lock, b.buffer be closed that is triggered when the maximum buffer size is reached, So check b.stop channel before access b.buf. Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>
|
Please set the appropriate release note label. |
|
LGTM, thanks for the fix! |
rolinh
approved these changes
Jun 24, 2020
rolinh
added
sig/hubble
gandro
approved these changes
Jun 24, 2020
|
test-me-please |
|
@Jianlin-lv Would you mind adding a unit test to cover this case? It should be pretty easy. |
michi-covalent
approved these changes
Jun 24, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
This was referenced Jun 26, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While waiting for b.mu.Lock, b.buffer be closed that is
triggered when the maximum buffer size is reached,
So check b.stop channel before access b.buf.
Signed-off-by: Jianlin Lv Jianlin.Lv@arm.com
Fixes: #12178