Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document test-only ci command #12268

Merged
merged 2 commits into from Oct 27, 2020
Merged

docs: document test-only ci command #12268

merged 2 commits into from Oct 27, 2020

Conversation

nebril
Copy link
Member

@nebril nebril commented Jun 24, 2020

No description provided.

@nebril nebril requested a review from a team as a code owner June 24, 2020 15:55
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Jun 24, 2020
@nebril nebril added the release-note/misc This PR makes changes that have no direct user impact. label Jun 24, 2020
@nebril
Copy link
Member Author

nebril commented Jun 24, 2020

link for reviewer convenience https://deploy-preview-12268--cilium-docs.netlify.app/contributing/testing/ci.html?highlight=test%20only

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.0 Jun 24, 2020
@coveralls
Copy link

coveralls commented Jun 24, 2020 •
edited

Coverage Status

Coverage increased (+0.03%) to 37.186% when pulling d6c175d on pr/document-test-only into 0dfe710 on master.

pchaigno
pchaigno reviewed Jun 26, 2020
View reviewed changes
Documentation/contributing/testing/ci.rst
+------------------------------------------------+-------------------------------------------+


Running Runtime test suite is still done via ``test-focus`` command.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is test-only for Runtime planned next or is there some limitation here? I understand having kernel_version and k8s_version won't make sense for Runtime tests, but might still be nice to have a single command; it would lead to less confusion.

@joestringer joestringer removed this from In progress in 1.8.0 Jun 26, 2020
@joestringer joestringer removed this from Needs backport from master in 1.8.0 Jun 26, 2020
@pchaigno
Copy link
Member

I've tried a couple of different test-only commands, but I can't seem to make it work... I always get:

The machine with the name 'k8s1-' was not found configured for
18:28:25  this Vagrant environment.

@christarazi
Copy link
Member

I am having trouble using this as well. I have the same issue as @pchaigno in #12482.

I also noticed that if I retrigger a test suite (e.g. retest-net-next), the "focused" test will run again, even though I didn't use test-only.

@stale
Copy link

stale bot commented Aug 13, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Aug 13, 2020
@stale
Copy link

stale bot commented Aug 28, 2020

This issue has not seen any activity since it was marked stale. Closing.

@stale stale bot closed this Aug 28, 2020
@nebril nebril reopened this Sep 15, 2020
@stale stale bot removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Sep 15, 2020
@nebril
Copy link
Member Author

nebril commented Sep 15, 2020

test-only --focus="K8sDemos"

@nebril
Copy link
Member Author

nebril commented Sep 15, 2020

I was unable to reproduce the issues that came @christarazi and @pchaigno encountered. Will try it one more time and merge if it passes.

@nebril
Copy link
Member Author

nebril commented Sep 15, 2020

test-only --focus="K8sDemos"

@pchaigno
Copy link
Member

I think it was failing with a bit more complicated requests (e.g., test-only --focus="K8sConformance Portmap Chaining Check connectivity-check compliance with portmap chaining" --kernel_version=49 --k8s_version=1.18).

@nebril
Copy link
Member Author

nebril commented Sep 15, 2020

test-only --focus="K8sConformance Portmap Chaining Check connectivity-check compliance with portmap chaining" --kernel_version=49 --k8s_version=1.18

@nebril
Copy link
Member Author

nebril commented Oct 26, 2020

test-only --focus="K8sConformance Portmap Chaining Check connectivity-check compliance with portmap chaining" --kernel_version=49 --k8s_version=1.17

@nebril
Copy link
Member Author

nebril commented Oct 26, 2020

test-me-please

@nebril nebril marked this pull request as ready for review October 26, 2020 11:39
pchaigno
pchaigno approved these changes Oct 26, 2020
View reviewed changes
Documentation/contributing/testing/ci.rst
| ``test-only --focus="K8sServicesTest"`` | Runs all k8s services tests |
+------------------------------------------------+-------------------------------------------+
| ``test-only --focus="K8sUpdates"`` | Runs k8s update tests |
+------------------------------------------------+-------------------------------------------+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not specific to this PR, but I never quite understood why we list each test group here. Wouldn't it be better to have a few examples of different commands instead?

@nebril
Copy link
Member Author

nebril commented Oct 27, 2020

test-net-next

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 27, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.0-rc3 Oct 27, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.5 Oct 27, 2020
@nebril nebril merged commit eb12b1f into master Oct 27, 2020
@nebril nebril deleted the pr/document-test-only branch October 27, 2020 12:03
@aditighag aditighag mentioned this pull request Oct 27, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.0-rc3 Oct 27, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.0-rc3 Oct 27, 2020
@christarazi christarazi mentioned this pull request Oct 27, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.5 Oct 27, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.5 Oct 27, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.0-rc3 Oct 28, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.5 Oct 28, 2020
@christarazi christarazi mentioned this pull request Oct 28, 2020
Merged
@joestringer joestringer mentioned this pull request Nov 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@christarazi christarazi christarazi approved these changes

@vadorovsky vadorovsky vadorovsky approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.1
Awaiting triage
1.8.5
Backport done to v1.8
1.9.0-rc3
Backport done to v1.9
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@nebril @coveralls @pchaigno @christarazi @vadorovsky @aanm @jrajahalme @aditighag