Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Mark host-policies as tech preview #12272

Merged
merged 1 commit into from Jun 25, 2020
Merged

docs: Mark host-policies as tech preview #12272

merged 1 commit into from Jun 25, 2020

Conversation

joestringer
Copy link
Member

The Cilium v1.8 blog describes this feature as tech preview, make sure
the docs are consistent with this.

@joestringer
docs: Mark host-policies as tech preview
c5c4a3c 
The Cilium v1.8 blog describes this feature as tech preview, make sure
the docs are consistent with this.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Jun 24, 2020
@joestringer joestringer requested a review from a team as a code owner June 24, 2020 18:13
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.1 Jun 24, 2020
pchaigno
pchaigno approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between beta and tech preview? We have header for both now.

@joestringer
Copy link
Member Author

I was wondering about that myself, we should come up with criteria and define what these mean :-)

@rolinh
Copy link
Member

rolinh commented Jun 24, 2020

Should we also apply this change to doc that refer to Hubble Relay? It's also "tech preview". I think the doc currently mentions it's "beta" but this generic warning seems better.

@coveralls
Copy link

coveralls commented Jun 24, 2020 •
edited

Coverage Status

Coverage increased (+0.02%) to 37.192% when pulling c5c4a3c on joestringer:submit/host-policies-tech-preview-docs into d4b7936 on cilium:master.

@joestringer
Copy link
Member Author

@rolinh filed #12280 to follow up on this. I think it'd be good to have a discussion on what we mean when we use these terms and how we decide to apply them.

@joestringer joestringer merged commit 09ca755 into cilium:master Jun 25, 2020
@joestringer joestringer deleted the submit/host-policies-tech-preview-docs branch June 25, 2020 18:54
This was referenced Jun 26, 2020
Closed
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.8 in 1.8.1 Jun 30, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.8 in 1.8.1 Jun 30, 2020
@pchaigno pchaigno added the area/host-firewall Impacts the host firewall or the host endpoint. label Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@qmonnet qmonnet qmonnet approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

@tgraf tgraf Awaiting requested review from tgraf

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/host-firewall Impacts the host firewall or the host endpoint. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.1
Backport done to v1.8
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@joestringer @rolinh @coveralls @pchaigno @qmonnet @michi-covalent @jrfastab