Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hubble/peer: prevent pushing to buffer when it's closed #12285

Merged
merged 1 commit into from Jun 25, 2020
Merged

hubble/peer: prevent pushing to buffer when it's closed #12285

merged 1 commit into from Jun 25, 2020

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Jun 25, 2020

Pushing to the buffer when it's closed should not be possible as the buffer can't be drained.
This commit updates Pop() to ensure an error is returned when trying to call it when the buffer is closed.

@rolinh
hubble/peer: prevent pushing to buffer when it's closed
0c3a3c0 
Pushing to the buffer when it's closed should not be possible as the
buffer can't be drained. This commit updates `Pop()` to ensure an error
is returned when trying to call it when the buffer is closed.

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh added release-note/bug This PR fixes an issue in a previous release of Cilium. sig/hubble Impacts hubble server or relay needs-backport/1.8 labels Jun 25, 2020
@rolinh rolinh requested a review from a team June 25, 2020 11:41
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.1 Jun 25, 2020
@rolinh
Copy link
Member Author

rolinh commented Jun 25, 2020

test-me-please

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0006%) to 37.168% when pulling 0c3a3c0 on pr/rolinh/hubble-peer-push-stop into dc2c161 on master.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 25, 2020
@joestringer joestringer merged commit 21b86d5 into master Jun 25, 2020
@joestringer joestringer deleted the pr/rolinh/hubble-peer-push-stop branch June 25, 2020 18:55
This was referenced Jun 26, 2020
Closed
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.1 Jun 26, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.1 Jun 26, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.1 Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium. sig/hubble Impacts hubble server or relay
Projects
No open projects
1.8.1
Backport done to v1.8
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rolinh @coveralls @gandro @michi-covalent @joestringer @jrfastab