Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix enableIdentityMark helm chart option #12299

Merged
merged 1 commit into from Jun 26, 2020

Conversation

aanm
Copy link
Member

@aanm aanm commented Jun 26, 2020

This option exist in the 'config' chart so we should set it with
config.enableIdentityMark and not with `global.enableIdentityMark'

Fixes: 1cc79c1 ("cilium: chaining mode skb->mark can be mangled by iptables allow opt-out")
Signed-off-by: André Martins andre@cilium.io

This option exist in the 'config' chart so we should set it with
`config.enableIdentityMark` and not with `global.enableIdentityMark'

Fixes: 1cc79c1 ("cilium: chaining mode skb->mark can be mangled by iptables allow opt-out")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.8 labels Jun 26, 2020
@aanm aanm requested review from a team as code owners June 26, 2020 11:33
@aanm aanm requested a review from a team June 26, 2020 11:33
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.1 Jun 26, 2020
@aanm aanm requested a review from jrfastab June 26, 2020 11:37
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 36.932% when pulling 5bb5c5a on aanm:pr/fix-helm-identity-mark-chart into b99c7b8 on cilium:master.

@aanm aanm merged commit f62bd84 into cilium:master Jun 26, 2020
@aanm aanm deleted the pr/fix-helm-identity-mark-chart branch June 26, 2020 17:40
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.1 Jun 30, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.1 Jun 30, 2020
@joestringer joestringer moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.1 Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
1.8.1
Backport done to v1.8
Development

Successfully merging this pull request may close these issues.

None yet

6 participants