Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.travis: Fix probes_test failure on Arm64 #12335

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

Jianlin-lv
Copy link
Contributor

Have no available kernel config in LXD container for arm64

Signed-off-by: Jianlin Lv Jianlin.Lv@arm.com

Fixes: #12322

Have no available kernel config in LXD container for arm64

Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>
@Jianlin-lv Jianlin-lv requested a review from a team June 30, 2020 11:01
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 30, 2020
@coveralls
Copy link

coveralls commented Jun 30, 2020

Coverage Status

Coverage increased (+0.03%) to 36.939% when pulling 78bee14 on Jianlin-lv:pr-fix-probes-issue into 655c636 on cilium:master.

@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Jun 30, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 30, 2020
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that ErrKernelConfigNotFound is a type rather than a sentinel error value. But this is not a problem with this PR but something we should address separately.

This PR LGTM, thanks.

@tklauser
Copy link
Member

No need to run Jenkins CI, this change is already covered by Travis CI, which suceeded for ARM64: https://travis-ci.com/github/cilium/cilium/jobs/355785768

Thus, marking as ready-to-merge.

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Travis CI: Kernel Config file not found in ProbesTestSuite.TestSystemConfigProbes
4 participants