v1.7 backports 2020-06-30 #12337
Merged
v1.7 backports 2020-06-30 #12337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ync was successful [ upstream commit e2cd4b7 ] Cloud APIs can get into a bad state. This could result in the operator being restarted. If that happens and the Cloud API synchronization then failed the CiliumNode resource would have its status overwritten. This is not desirable. Require a sucessful Cloud API sync before updating the CiliumNode resource. Fixes: #11052 Signed-off-by: Thomas Graf <thomas@cilium.io> Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
[ upstream commit 7947ac9 ] The initial synchronization is blocking but did not return the error so far. Treat the initial synchronization as critical. If that can't succeed, restart the operator to indicate the problem. IP allocation will not succeed anyway. Signed-off-by: Thomas Graf <thomas@cilium.io> Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
maintainer-s-little-helper
bot
added
backport/1.7
kind/backports
|
test-backport-1.7 |
nebril
force-pushed
the
pr/1.7-backports-30-06.2020
branch
from
cb9d515
to
a5a6460
Compare
|
test-backport-1.7 |
|
test-missed-k8s |
joestringer
requested changes
Jul 1, 2020
…nstable [ upstream commit b5c5ca9 ] It is possible for the cloud APIs being used by the operator to get into a state where POST and PATCH operations are still succeeding while GET operations are failing. This can result in the operator to continously creating resources while being unable to ever synchronize the state successfully. Require a successful synchronization of all resources in order to continue performing mutating operations. Signed-off-by: Thomas Graf <thomas@cilium.io> Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
nebril
force-pushed
the
pr/1.7-backports-30-06.2020
branch
from
a5a6460
to
09ed88c
Compare
|
test-backport-1.7 |
|
test-missed-k8s |
|
@joestringer fixed, but I think it would be good to have @tgraf take a look as original author |
tgraf
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, you can update the PR labels via: