v1.7 fix - test/bpf: use nproc --all instead of nproc -all
#12401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the __NR_CPUS__ definitions were change to use nproc --all in commit 6247cc5 ("bpf: Use `nproc --all` for __NR_CPUS__") via #12363 the change in test/bpf/Makefile was missing a `-`, leading to the following error message in the v1.8 build: make -C test/bpf/ nproc: invalid option -- 'a' Try 'nproc --help' for more information. While this is uncritical for the tests and the build, but fix it nevertheless to get rid of the error message. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
maintainer-s-little-helper
bot
added
backport/1.7
kind/backports
|
test-backport-1.7 |
tgraf
approved these changes
Jul 3, 2020
aanm
approved these changes
Jul 3, 2020
pchaigno
approved these changes
Jul 4, 2020
gandro
approved these changes
Jul 6, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
__NR_CPUS__definitions were change to usenproc --allin commit6247cc5 ("bpf: Use
nproc --allfor__NR_CPUS__") via #12363 thechange in test/bpf/Makefile was missing a
-, leading to the followingerror message in the v1.8 build:
While this is uncritical for the tests and the build, but fix it
nevertheless to get rid of the error message.