Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move update-ec2-apdater-limit-via-api flag to be on the cilium-operator-aws binary #12410

Merged
merged 1 commit into from Jul 6, 2020
Merged

Move update-ec2-apdater-limit-via-api flag to be on the cilium-operator-aws binary #12410

merged 1 commit into from Jul 6, 2020

Conversation

ungureanuvladvictor
Copy link
Member

Signed-off-by: Vlad Ungureanu vladu@palantir.com

While we did the operator functionality split this flag was missed and not added to the aws version of the operator.

Fixes: d16af4a

Add the `update-ec2-apdater-limit-via-api` flag to the `cilium-operator-aws`.

@ungureanuvladvictor
Move update-ec2-apdater-limit-via-api flag to be on the cilium-operat…
6a8e03c 
…or-aws binary

Signed-off-by: Vlad Ungureanu <vladu@palantir.com>
@ungureanuvladvictor ungureanuvladvictor added pending-review release-note/bug This PR fixes an issue in a previous release of Cilium. area/operator Impacts the cilium-operator component integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. labels Jul 4, 2020
@ungureanuvladvictor ungureanuvladvictor requested a review from a team as a code owner July 4, 2020 22:26
@ungureanuvladvictor
Copy link
Member Author

test-me-please

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 36.934% when pulling 6a8e03c on vladu/move-aws-flag into 082e879 on master.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 6, 2020
@aanm aanm merged commit 9bc07f4 into master Jul 6, 2020
@aanm aanm deleted the vladu/move-aws-flag branch July 6, 2020 08:47
@joestringer joestringer mentioned this pull request Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
area/operator Impacts the cilium-operator component integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ungureanuvladvictor @coveralls @christarazi @aanm