Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds documentation for limiting identity-relevant labels used when evaluating Cilium Identities #12517

Merged
merged 2 commits into from Jul 15, 2020
Merged

Conversation

seanmwinn
Copy link
Contributor

Adds documentation for limiting identity-relevant labels used when evaluating Cilium Identities
Fixes: #11540
Signed-off-by: Sean Winn sean@isovalent.com

Fixes: #11540
Signed-off-by: Sean Winn <sean@isovalent.com>
@seanmwinn seanmwinn requested a review from a team as a code owner July 13, 2020 18:27
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 13, 2020
@seanmwinn seanmwinn added the release-note/misc This PR makes changes that have no direct user impact. label Jul 13, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 13, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.6.11 Jul 13, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.2 Jul 13, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.7.7 Jul 13, 2020
@coveralls
Copy link

coveralls commented Jul 13, 2020

Coverage Status

Coverage decreased (-0.003%) to 37.002% when pulling a1a8e23 on seanmwinn:cilium-11540 into b0610a4 on cilium:master.

@pchaigno pchaigno added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Jul 13, 2020
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Mostly nits below from me :-)

Documentation/gettingstarted/index.rst Outdated Show resolved Hide resolved
Documentation/gettingstarted/identity-relevant-labels.rst Outdated Show resolved Hide resolved
Documentation/gettingstarted/identity-relevant-labels.rst Outdated Show resolved Hide resolved
Documentation/gettingstarted/identity-relevant-labels.rst Outdated Show resolved Hide resolved
Documentation/gettingstarted/identity-relevant-labels.rst Outdated Show resolved Hide resolved
Documentation/gettingstarted/identity-relevant-labels.rst Outdated Show resolved Hide resolved
Documentation/gettingstarted/identity-relevant-labels.rst Outdated Show resolved Hide resolved
Documentation/gettingstarted/identity-relevant-labels.rst Outdated Show resolved Hide resolved
Documentation/gettingstarted/identity-relevant-labels.rst Outdated Show resolved Hide resolved
Signed-off-by: Sean Winn <sean@isovalent.com>
@qmonnet qmonnet merged commit a5fe80e into cilium:master Jul 15, 2020
@qmonnet
Copy link
Member

qmonnet commented Jul 15, 2020

Seeing that this is marked for backports, but that Documentation/concepts/scalability/index.rst does not exist in v1.6/v1.7, where would you like to include the file?

@brb brb mentioned this pull request Jul 15, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.2 Jul 15, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.2 Jul 20, 2020
This was referenced Jul 21, 2020
@christarazi
Copy link
Member

This PR has two commits which should have been squashed into one. We should look out for things like this next time before merging. :)

@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.7 in 1.7.7 Jul 23, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.7 Jul 23, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.6 in 1.6.11 Jul 29, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.6 in 1.6.11 Jul 29, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.6 to Backport done to v1.6 in 1.6.11 Jul 30, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.6 to Backport done to v1.6 in 1.6.11 Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.6.11
Backport done to v1.6
1.7.7
Backport done to v1.7
1.8.2
Backport done to v1.8
Development

Successfully merging this pull request may close these issues.

Docs: Provide description/example of using non-default "labels"
7 participants