Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile, contrib: Add script to create kind cluster #12527

Merged

Conversation

christarazi
Copy link
Member

@christarazi christarazi commented Jul 15, 2020

We have the equivalent for minikube.

Usage:

$ ./contrib/scripts/kind.sh
$ # or
$ make kind

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 15, 2020
@christarazi christarazi added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. labels Jul 15, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 15, 2020
@coveralls

This comment has been minimized.

@rolinh
Copy link
Member

rolinh commented Jul 15, 2020

* Find a way to parameterize the number of workers (not sure how
  necessary this is)

I use kind a lot for Hubble Relay development and, in this context, being able to test with 4+ nodes is super useful (I've created kind clusters up to 50 nodes).

However, I also found out that I don't need a local registry as I can just kind load docker-image cilium/hubble-relay:latest (and any other relevant image) followed by kubectl delete pods .... This works because the pull policy is IfNotPresent and if there are multiple images with the same tag, the most recent one is picked.

@sayboras
Copy link
Member

I love kind a lot as well. Have been using it as part of local development and testing.

Related on number of node, here is the configuration we used in smoke test with one tweak to make sure that the control plan is available for scheduling. https://github.com/cilium/cilium/blob/master/.github/kind-config.yaml#L6

@christarazi christarazi force-pushed the pr/christarazi/add-kind-cluster-script branch 5 times, most recently from 035304b to 44605a5 Compare July 27, 2020 23:41
@christarazi christarazi force-pushed the pr/christarazi/add-kind-cluster-script branch from 44605a5 to 035304b Compare August 15, 2020 01:11
@stale

This comment has been minimized.

@stale stale bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Sep 14, 2020
@christarazi christarazi removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Sep 14, 2020
@aanm aanm added the needs/triage This issue requires triaging to establish severity and next steps. label Oct 13, 2020
@stale

This comment has been minimized.

@stale stale bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Nov 14, 2020
@sayboras sayboras removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Nov 14, 2020
@joestringer
Copy link
Member

FWIW, I feel it'd be kinda nice to have some convenience script for this in the tree, occasionally I use the steps from the conformance tests + .github/kind-config.yaml to deploy a kind config but I always have to look it up again whenever I try it out.

@christarazi
Copy link
Member Author

Yeah, I think it's worth dusting off this PR and getting it out even though it doesn't meet all the TODOs marked in the PR description. I often switch to this branch locally, create my kind cluster, then switch back to my dev branch 😅.

/cc @sayboras, he had a similar PR out and might be worth figuring out which one to move forward and whether to consolidate.

@sayboras
Copy link
Member

sayboras commented Dec 1, 2020

@joestringer @christarazi 👋 oh the pending PR I got is my local script to quickly run conformance test. There are few comments which I need to address, but didn't have time recently. I will plan sometimes to clean it up, anyway, happy to discuss how to move forward in either case 😃

@stale

This comment has been minimized.

@stale stale bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jan 10, 2021
@christarazi christarazi removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jan 10, 2021
@christarazi christarazi force-pushed the pr/christarazi/add-kind-cluster-script branch 3 times, most recently from f3a77cb to e637082 Compare February 19, 2021 22:06
@christarazi christarazi changed the title contrib: Add script to create kind cluster Makefile, contrib: Add script to create kind cluster May 13, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.0-rc2 May 13, 2021
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Are you planning to add more steps to install cilium to the same script?

contrib/scripts/kind.sh Show resolved Hide resolved
@aanm aanm added this to Needs backport from master in 1.10.0-rc3 May 17, 2021
@aanm aanm removed this from Needs backport from master in 1.10.0-rc2 May 17, 2021
@aanm aanm added this to Needs backport from master in 1.10.1 May 19, 2021
@aanm aanm removed this from Needs backport from master in 1.10.0-rc3 May 19, 2021
@christarazi christarazi removed the request for review from michi-covalent May 25, 2021 17:27
@aanm aanm merged commit ff9be87 into cilium:master May 28, 2021
@christarazi christarazi deleted the pr/christarazi/add-kind-cluster-script branch May 28, 2021 05:06
@qmonnet qmonnet mentioned this pull request Jun 1, 2021
23 tasks
@aanm aanm moved this from Needs backport from master to Backport done to v1.10 in 1.10.1 Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/triage This issue requires triaging to establish severity and next steps. release-note/misc This PR makes changes that have no direct user impact. sig/contributing Impacts contribution workflow, guidelines, and tools.
Projects
No open projects
1.10.1
Backport done to v1.10
Development

Successfully merging this pull request may close these issues.

None yet

10 participants