test: Improve logging of errors that must be investigated #12598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only print the unique logs, and ensure they're printed not only to the checker output but also to the regular ginkgo output. Signed-off-by: Joe Stringer <joe@cilium.io>
pchaigno
approved these changes
Jul 20, 2020
|
test-me-please |
brb
approved these changes
Jul 21, 2020
| failures := make([]string, 0, len(uniqueFailures)) | ||
| for f, c := range uniqueFailures { | ||
| failures = append(failures, f) | ||
| fmt.Fprintf(CheckLogs, "⚠️ Found %q in logs %d times\n", f, c) |
There was a problem hiding this comment.
Bikeshedding nit: does the ⚠️ char serve any purpose in the log msg?;-)
There was a problem hiding this comment.
It's been a while since I even thought about it but the idea is to highlight this concern in the output. It certainly gives these particular messages a certain aesthetic, breaking up the flow of the log output and helps to highlights this output (though these days there's always false positives due to certain logs triggered by our CI system :( )
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only print the unique logs, and ensure they're printed not only to the
checker output but also to the regular ginkgo output.