-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fqdn/dnsproxy: set SO_REUSEPORT on listening socket #12728
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we start re-using the same port for the DNS proxy across restarts (see #12718), set the SO_REUSEPORT option on the listening port. This given the proxy a better chance to re-bind() upon restarts. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
maintainer-s-little-helper
bot
added
the
kind/backports
This PR provides functionality previously merged into master.
label
Jul 31, 2020
tklauser
added
the
area/proxy
Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers.
label
Jul 31, 2020
test-backport-1.7 |
tklauser
added
the
release-note/misc
This PR makes changes that have no direct user impact.
label
Jul 31, 2020
qmonnet
approved these changes
Jul 31, 2020
sayboras
reviewed
Jul 31, 2020
sayboras
approved these changes
Jul 31, 2020
tgraf
approved these changes
Jul 31, 2020
8 tasks
tklauser
added a commit
that referenced
this pull request
Aug 6, 2020
Forward port of #12728 Once we start re-using the same port for the DNS proxy across restarts (see #12794), it's useful to set the SO_REUSEPORT option on the listening port. This given the proxy a better chance to re-bind() upon restarts. Updates #12794 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
added a commit
that referenced
this pull request
Aug 7, 2020
Forward port of #12728 Once we start re-using the same port for the DNS proxy across restarts (see #12794), it's useful to set the SO_REUSEPORT option on the listening port. This given the proxy a better chance to re-bind() upon restarts. Updates #12794 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
jrajahalme
pushed a commit
that referenced
this pull request
Aug 7, 2020
[ upstream commit 3abd218 ] Forward port of #12728 Once we start re-using the same port for the DNS proxy across restarts (see #12794), it's useful to set the SO_REUSEPORT option on the listening port. This given the proxy a better chance to re-bind() upon restarts. Updates #12794 Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
tklauser
added a commit
that referenced
this pull request
Aug 10, 2020
[ upstream commit 3abd218 ] Forward port of #12728 Once we start re-using the same port for the DNS proxy across restarts (see #12794), it's useful to set the SO_REUSEPORT option on the listening port. This given the proxy a better chance to re-bind() upon restarts. Updates #12794 Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/proxy
Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers.
kind/backports
This PR provides functionality previously merged into master.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we start re-using the same port for the DNS proxy across
restarts (see #12718), set the
SO_REUSEPORT
option on the listeningport. This given the proxy a better chance to re-bind() upon restarts.