[v1.7] Extend FQDN test to validate DNS proxy during restart #12739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit splits out the function to test connectivity into components to be reused. The call sites are consolidated. Signed-off-by: Chris Tarazi <chris@isovalent.com>
This can be removed now that cilium#12718 has been merged. The aforementioned PR should improve the DNS connectivity downtime when Cilium is restarting. Related: cilium#12731 Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
added
area/CI
maintainer-s-little-helper
bot
added
backport/1.7
kind/backports
|
test-backport-1.7 |
This commit reworks how the FQDN test is run. It now validates that connectivity is still available during a Cilium restart, instead of waiting until Cilium is back up. This allows validating cilium#12718 and cilium#12731 improving the time it takes the procy to respond to DNS requests. Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
force-pushed
the
pr/christarazi/v1.7-extend-fqdn-test
branch
from
ab83d99
to
b4b4f6c
Compare
|
test-backport-1.7 |
tklauser
approved these changes
Aug 3, 2020
|
test-backport-1.7 Edit: failures unrelated |
|
test-backport-1.7 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit msgs.
We can consider forward-porting this to newer branches +
master, if deemed valuable.Follow up from #12718 and
#12731