[1.7] etcd: Disable heartbeat quorum check by default #12755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diable the heartbeat check by default as the sudden requirement for the cilium-operator to be always available can come to a surprise to existing 1.7 users. Require etcd.enableHeartbeat=true to be set in order to enable the requirement for the heartbeat. Signed-off-by: Thomas Graf <thomas@cilium.io>
maintainer-s-little-helper
bot
added
the
kind/backports
|
test-backport-1.7 |
joestringer
approved these changes
Aug 3, 2020
There was a problem hiding this comment.
How is this configured? Is it by editing the configmap to extend kvstore-opt like the below?
kvstore-opt: '{"etcd.config": "/var/lib/etcd-config/etcd.config", "etcd.enableHeartbeat": "true"}'
And given this only modifies the client side, I assume that the heartbeat will still be written and assuming we get the right command, it's possible to check whether the heartbeat is working at runtime? Let's say for instance if you suspect a quorum issue in this v1.7 branch.
maintainer-s-little-helper
bot
added
ready-to-merge
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the heartbeat check by default as the sudden requirement for the
cilium-operator to be always available can come to a surprise to existing 1.7
users.
Require etcd.enableHeartbeat=true to be set in order to enable the requirement
for the heartbeat.