install/kubernetes: do not schedule cilium-operator pods in same node #12771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
kind/bug
|
test-me-please |
christarazi
approved these changes
Aug 4, 2020
install/kubernetes/cilium/charts/operator/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
|
Coverage decreased (-0.02%) to 36.839% when pulling 4189fc4f1180e4c008e79191f3d2803ae9e64397 on aanm:pr/fix-cilium-operator-ha into 9606ff5 on cilium:master. |
joestringer
approved these changes
Aug 4, 2020
|
We'll wait for CI results then we can fix up the cosmetic nit & merge (assuming CI is happy). |
Since Cilium Operator is running in host network, 2 or more pods can't run in the same node at the same time or they will clash the open ports they use for liveness and / or readiness health check. Fixes: 930bde7 ("install: update helm templates to add HA capabilities for operator") Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/fix-cilium-operator-ha
branch
from
4189fc4
to
dedfd24
Compare
|
CI was green. I've pushed the requested changes which doesn't require another CI run. |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.3
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.7
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.7
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.3
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.3
aanm
added
release-note/misc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Cilium Operator is running in host network, 2 or more pods can't
run in the same node at the same time or they will clash the open
ports they use for liveness and / or readiness health check.
Fixes: 930bde7 ("install: update helm templates to add HA capabilities for operator")
Signed-off-by: André Martins andre@cilium.io