Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CODEOWNERS: Update Kubernetes owners #12883

Merged
merged 2 commits into from Aug 14, 2020
Merged

CODEOWNERS: Update Kubernetes owners #12883

merged 2 commits into from Aug 14, 2020

Conversation

christarazi
Copy link
Member

@christarazi christarazi commented Aug 14, 2020 •
edited

  • examples/crds/ are where generated CRDs are kept.
  • pkg/k8s/apis/cilium.io/v2 contains Kubernetes related code especially
    inside validator.

Also fix a few typos.

@christarazi
CODEOWNERS: Update Kubernetes owners
c85014b 
- examples/crds/ are where generated CRDs are kept.
- pkg/k8s/apis/cilium.io/v2 contains Kubernetes related code especially
  inside `validator`.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi requested a review from a team as a code owner August 14, 2020 06:20
@christarazi christarazi added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. labels Aug 14, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 14, 2020
@christarazi christarazi requested review from aanm and a team August 14, 2020 06:21
@christarazi
CODEOWNERS: Fix typo for pkg/{launcher,lock}
90b8c37 
Signed-off-by: Chris Tarazi <chris@isovalent.com>
@coveralls
Copy link

coveralls commented Aug 14, 2020 •
edited

Coverage Status

Coverage decreased (-0.02%) to 37.108% when pulling 90b8c37 on christarazi:pr/christarazi/update-k8s-codeowners into df36783 on cilium:master.

fristonio
fristonio approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@fristonio fristonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@aanm aanm merged commit dfdeb69 into cilium:master Aug 14, 2020
@christarazi christarazi deleted the pr/christarazi/update-k8s-codeowners branch August 14, 2020 16:30
@christarazi christarazi mentioned this pull request Aug 14, 2020
Closed
@joestringer joestringer mentioned this pull request Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

@rolinh rolinh rolinh approved these changes

@pchaigno pchaigno pchaigno approved these changes

@aanm aanm aanm approved these changes

@sayboras sayboras sayboras approved these changes

@fristonio fristonio fristonio approved these changes

Assignees
No one assigned
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@christarazi @coveralls @kaworu @rolinh @pchaigno @aanm @sayboras @fristonio