doc: Document seamless upgrade process for remote-node identity change #13042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upgrade instructions have been incomplete and did not allow for a seamless upgrade from 1.6.x to 1.7.0. Signed-off-by: Thomas Graf <thomas@cilium.io>
tgraf
added
area/documentation
maintainer-s-little-helper
bot
added
the
kind/backports
christarazi
approved these changes
Sep 1, 2020
joestringer
approved these changes
Sep 1, 2020
Comment on lines
+484
to
+495
| 3. A third rolling upgrade must be performed with the option | ||
| ``allow-host-src: false`` set. This will enable the additional security | ||
| check and start dropping traffic originating from the host identity | ||
| received over the network. It is important to make this change | ||
| independent of enabling the transmission to a avoid a mix of nodes with | ||
| restrictive receive behavior while old nodes are still transmitting with | ||
| the legacy host identity. | ||
|
|
||
| 4. Network policies must be audited to ensure policies no longer allow on the | ||
| old behavior of the host entity allowing from all nodes in the cluster. | ||
| After this step has been completed, remote node identity policy can be | ||
| enabled by setting ``enable-remote-node-identity: true``. |
There was a problem hiding this comment.
I wonder whether there is a practical difference to splitting these into separate steps or whether they could be combined together? Until step 4 is executed, from a policy perspective, allows "from host" will still allow traffic from remote nodes.
|
test-docs-please |
|
We can iterate further on top if necessary, merged. It likely also makes sense for us to revisit forward-porting these docs changes to master / v1.8 given that these instructions are also present there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #13038
The upgrade instructions have been incomplete and did not allow for a
seamless upgrade from 1.6.x to 1.7.0.