github-workflow: Reduce scope of quick-install test #13078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgraf
added
the
release-note/misc
fristonio
requested changes
Sep 4, 2020
The current quick-install tests deployment of the quickinstall yaml without building new images and then runs the connectivity check. THis is problematic as it means that no change will pass the test where a helm template change depends on a code change. The connectivity test is already being run in the "conformance-test" test where images are being built properly. There is a small diff in the options bein used in the "conformance-test" and the default options in the quickinstall YAML but nothing that wouldn't be covered by the overall CI anyway. Reduce the scope of the quick-install test to validate that the quickinstall YAML is not outdated. Signed-off-by: Thomas Graf <thomas@cilium.io>
tgraf
force-pushed
the
pr/tgraf/remove-quick-install-test
branch
from
9c09287
to
f6a62e4
Compare
tgraf
changed the title
sayboras
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current quick-install tests deployment of the quickinstall yaml
without building new images and then runs the connectivity check. THis
is problematic as it means that no change will pass the test where a
helm template change depends on a code change.
The connectivity test is already being run in the "conformance-test"
test where images are being built properly.
There is a small diff in the options bein used in the "conformance-test"
and the default options in the quickinstall YAML but nothing that
wouldn't be covered by the overall CI anyway.
Reduce the scope of the quick-install test to validate that the
quickinstall YAML is not outdated.