Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging_fix: Adding logs in a structured way #13120

Merged
merged 3 commits into from Sep 9, 2020
Merged

logging_fix: Adding logs in a structured way #13120

merged 3 commits into from Sep 9, 2020

Conversation

chowmean
Copy link
Contributor

@chowmean chowmean commented Sep 8, 2020 •
edited by aanm

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Fixes: #12818

Add logs in a structured way for operator leader re-election in HA mode

@chowmean
adding logs in strcutured way
d1cd8e9 
Signed-off-by: Gaurav Yadav <gaurav.dev.iiitm@gmail.com>
@chowmean chowmean requested a review from a team as a code owner September 8, 2020 19:36
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 8, 2020
pchaigno
pchaigno reviewed Sep 8, 2020
View reviewed changes
operator/main.go Outdated Show resolved Hide resolved
@pchaigno pchaigno added the release-note/misc This PR makes changes that have no direct user impact. label Sep 8, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 8, 2020
@chowmean
adding info message in log
f77d279 
Signed-off-by: Gaurav Yadav <gaurav.dev.iiitm@gmail.com>
@aanm aanm requested a review from fristonio September 9, 2020 09:31
fristonio
fristonio requested changes Sep 9, 2020
View reviewed changes
operator/main.go Outdated Show resolved Hide resolved
operator/main.go Outdated Show resolved Hide resolved
@chowmean
changing operator ID and identity
b2fc2f3 
Signed-off-by: Gaurav Yadav <gaurav.dev.iiitm@gmail.com>
fristonio
fristonio approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@fristonio fristonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the pull request 🎉

@aanm
Copy link
Member

aanm commented Sep 9, 2020

it's a small change, no need to run the CI

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.4 Sep 9, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.7.10 Sep 9, 2020
@aanm aanm merged commit 3d6cf1b into cilium:master Sep 9, 2020
@kkourt kkourt mentioned this pull request Sep 16, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.4 Sep 16, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.4 Sep 17, 2020
@joestringer joestringer mentioned this pull request Sep 17, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.7 in 1.7.10 Sep 17, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.10 Sep 18, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.10 Sep 18, 2020
brb
brb reviewed Sep 28, 2020
View reviewed changes
operator/main.go Show resolved Hide resolved
This was referenced Sep 30, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb left review comments

@aanm aanm aanm left review comments

@pchaigno pchaigno pchaigno approved these changes

@fristonio fristonio fristonio approved these changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.7.10
Backport done to v1.7
1.8.4
Backport done to v1.8
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify operator leader election event log for non-leaders
7 participants
@chowmean @aanm @brb @pchaigno @fristonio @kkourt @joestringer