service: Fix panic when restoring services with enable-health-check-nodeport: false #13190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odeport: false We do not instanciate the service health server if HealthCheckNodePort support is disabled in our kube-proxy replacement. This means that we need to check the `EnableHealthCheckNodePort` flag before accessing the service health server to avoid a nil pointer panic. Fixes: edff374 ("agent: Add an option to cilium-agent for disabling 'HealthCheckNodePort'") Fixes: #13178 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
When HealthCheckNodePort is false, then the service health server will be nil. This commit adds a unit test to ensure that the code does not crash if the service health server is nil. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
added
release-note/bug
aanm
approved these changes
Sep 16, 2020
|
test-me-please |
aanm
deleted the
pr/gandro/fix-nil-pointer-if-healthchecknodeport-is-disabled
branch
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.10
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.4
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.4
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.10
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.10
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not instantiate the service health server if
HealthCheckNodePortsupport is disabled in our kube-proxy replacement. This means that we
need to check the
EnableHealthCheckNodePortflag before accessing theservice health server to avoid a nil pointer panic.
This PR also adds a unit test to catch potential regressions.
Fixes: edff374 ("agent: Add an option to cilium-agent for disabling 'HealthCheckNodePort'")
Fixes: #13178
Note to backporters: The unit test (second commit) may be skipped for backports if it causes non-trivial conflicts.