test: auto correct grafana port in test vagrant vms #13202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not having auto_correct set to true caused concurrent vagrant envs to conflict on host port 3000 which caused builds to fail Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
test-missed-k8s |
|
test-me-please |
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
aanm
approved these changes
Sep 17, 2020
|
I'm going to merge this since all required tests have passed. The #13199 will run the tests for the missed k8s versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not having auto_correct set to true caused concurrent vagrant envs
to conflict on host port 3000 which caused builds to fail