Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vagrant: Bump all Vagrant box versions #13341

Merged
merged 2 commits into from Sep 30, 2020
Merged

vagrant: Bump all Vagrant box versions #13341

merged 2 commits into from Sep 30, 2020

Conversation

pchaigno
Copy link
Member

Fixes: #11255

@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. labels Sep 30, 2020
@pchaigno
vagrant: Bump all Vagrant box versions
c26a25b 
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno
maps: Use fmt.Sprint() instead of string()
d8e7017 
Otherwise, the privileged unit tests fail with:

  pkg/maps/eppolicymap/eppolicymap_test.go:72:32: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno
Copy link
Member Author

test-me-please

@pchaigno pchaigno marked this pull request as ready for review September 30, 2020 16:44
@pchaigno pchaigno requested a review from a team September 30, 2020 16:44
@pchaigno pchaigno requested a review from a team as a code owner September 30, 2020 16:44
tklauser
tklauser approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the failure fixed by the maps: Use fmt.Sprint() instead of string() commit only showed up now due to the Go version bump in the new Vagrant box?

@pchaigno
Copy link
Member Author

I assume the failure fixed by the maps: Use fmt.Sprint() instead of string() commit only showed up now due to the Go version bump in the new Vagrant box?

Yeah, that's my assumption since the VM image update includes a Go update, it didn't occur on previous VM images, and I was able to easily reproduce locally with the new VM image.

@pchaigno
Copy link
Member Author

Net-next CI build hit known flake #13062. Other builds are passing. Marking as ready-to-merge.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 30, 2020
@christarazi christarazi merged commit 641c0f9 into master Sep 30, 2020
@christarazi christarazi deleted the pr/update-packer-ci-build branch September 30, 2020 22:13
@joestringer joestringer mentioned this pull request Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"'stddef.h' file not found" in dev. VM
3 participants
@pchaigno @tklauser @christarazi