v1.8 backports 2020-09-30 #13352
Merged
v1.8 backports 2020-09-30 #13352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
added
backport/1.8
kind/backports
|
test-backport-1.8 |
[ upstream commit bfdaae9 ] This option was not being respected in the case where the user enables etcd configuration. In this case, when also configuring Cluster Mesh, it is important to manage identities via the kvstore to ensure that remote clusters have access to the identities of the local cluster. However, for users who are not using Cluster Mesh, it is reasonable to run Cilium with identities managed via CRDs, and deployments may already be deployed in this way. Failing to respect the option means that users who upgrade may observe temporary dataplane upgrade during upgrade due to the transition from CRD to kvstore for identity management. To prevent unintentional dataplane outage during upgrade from earlier releases, revert the helm changes from commit 8c95392 ("doc: Fix clustermesh documentation to set the correct identityMode"). The above commit already clarified the instructions for clustermesh users, which was the main goal of that commit so no other changes are necessary in this commit. Fixes: 8c95392 ("doc: Fix clustermesh documentation to set the correct identityMode") Reported-by: Dan Sexton <dan.b.sexton@gmail.com> Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
pr/v1.8-backport-2020-09-30
branch
from
2997c6a
to
b98df2c
Compare
|
test-backport-1.8 |
christarazi
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, you can update the PR labels via: