datapath/connector: remove unused funcs #13374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last remaining user of DeriveEndpointFrom was removed by commit 532ad9d ("rm pkg/workloads"). GetNetInfoFromPID and GetVethInfo were only used by DeriveEndpointFrom, so remove them as well. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
This function is only used in daemon/cmd in a single place, so move it there and unexport it. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
added
kind/cleanup
|
test-me-please |
vadorovsky
approved these changes
Oct 1, 2020
christarazi
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last remaining user of
DeriveEndpointFromwas removed by commit532ad9d ("rm pkg/workloads").
GetNetInfoFromPIDandGetVethInfowere only used by
DeriveEndpointFrom, so remove them as well.Also move the single-use function
CheckLinkto where it is used.