Fix Azure IPAM regression #13397
Merged
Fix Azure IPAM regression #13397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit dd99958 introduced support for multiple interfaces and added a new requirement for the gateway IP to be known. This is not always the case. Make it optional. This resulted in errors like these: ``` Warning FailedCreatePodSandBox 3m46s (x264 over 8m38s) kubelet, aks-nodepool1-10706209-vmss000001 (combined from similar events): Failed to create pod sandbox: rpc error: code = Unknown desc = failed to set up sandbox container "600afaf8013aac81bdd001e12f4ee115ef07a9c1520dc72b7c9c449a8f3f3b86" network for pod "coredns-869cb84759-jrxdd": networkPlugin cni failed to set up pod "coredns-869cb84759-jrxdd_kube-system" network: unable to setup interface datapath: unable to parse routing info: invalid ip: ``` Fixes: #13154 Fixes: dd99958 ("azure: support multiple pods subnets") Signed-off-by: Thomas Graf <thomas@cilium.io>
tgraf
added
kind/bug
When following the AKS installation instructions, there will be existing pods which are not managed by Cilium. Ask the user to restart them. Fixes: #13154 Signed-off-by: Thomas Graf <thomas@cilium.io>
tgraf
force-pushed
the
pr/tgraf/fix-azure-ipam
branch
from
a4fd0f2
to
cd40589
Compare
|
test-me-please |
|
The GKE test failed because the FQDN proxy can't bind to the port: Filed: #13400 |
|
test-gke |
aanm
approved these changes
Oct 5, 2020
|
Only 1.8 backport is needed, the bug is not present in 1.7. |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.5
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.