Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix minor issues in getting started guide #13419

Merged
merged 3 commits into from Oct 6, 2020
Merged

docs: Fix minor issues in getting started guide #13419

merged 3 commits into from Oct 6, 2020

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented Oct 6, 2020

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

This PR corrects a few minor issues found while working through the getting started guide. See the individual commits for descriptions.

@twpayne
docs: Correct app name in getting started guide
f252310 
Signed-off-by: Tom Payne <tom@isovalent.com>
@twpayne
docs: Add demonstration that second example is additive
6c7ef91 
This makes it clear that the L7 filter builds on the L3/L4 filter.

Signed-off-by: Tom Payne <tom@isovalent.com>
@twpayne twpayne requested a review from a team as a code owner October 6, 2020 09:41
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 6, 2020
@twpayne twpayne added the release-note/misc This PR makes changes that have no direct user impact. label Oct 6, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 6, 2020
pchaigno
pchaigno approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once Robin's comment is addressed.

@pchaigno pchaigno added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Oct 6, 2020
@twpayne
docs: Create connectivity test is separate namespace in getting start…
e14e6e8 
…ed guide

Signed-off-by: Tom Payne <tom@isovalent.com>
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 6, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.5 Oct 6, 2020
@gandro gandro merged commit 803f283 into cilium:master Oct 6, 2020
@twpayne twpayne deleted the pr/twpayne/getting-started-docs branch October 6, 2020 14:18
@qmonnet qmonnet mentioned this pull request Oct 7, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.5 Oct 7, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.5 Oct 9, 2020
@christarazi christarazi mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkourt kkourt kkourt approved these changes

@rolinh rolinh rolinh approved these changes

@pchaigno pchaigno pchaigno approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.5
Backport done to v1.8
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@twpayne @kkourt @rolinh @pchaigno @aanm @gandro @qmonnet