Backport OpenShift OKD docs for 1.8 #13443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
backport/1.8
kind/backports
errordeveloper
commented
Oct 7, 2020
errordeveloper
commented
Oct 7, 2020
[ upstream commit 43e6a4a ] Co-authored-by: Vadim Rutkovsky <roignac@gmail.com> Co-authored-by: Joe Stringer <joe@cilium.io> Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
[ upstream commit 2155815 ] Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
errordeveloper
force-pushed
the
pr/v1.8-backport-2020-10-07-okd-docs
branch
from
e429fff
to
4175d67
Compare
The rest of the guide relies on the use of `cilium-test` namespace which was added to connectivity test after 1.8. This simply backports that improvement inline just for the OpenShift OKD guide. Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
errordeveloper
added
the
ready-to-merge
gandro
reviewed
Oct 8, 2020
|
|
||
| .. note:: | ||
|
|
||
| Version ``1.8-dev`` has bug fixes for OpenShift, those fixes will get included in 1.8.5. |
There was a problem hiding this comment.
Shouldn't we just recommend here that users simply deploy least Cilium 1.8.5? I know it has not been released yet, but I find it a bit weird to refer to development version in the stable docs.
There was a problem hiding this comment.
Due to popular demand the intention is to give a preview to folks ASAP, hence it's even being backported :)
There was a problem hiding this comment.
It's a bit as if we made an RC for 1.8.5, but it turns out we don't do RCs for patch releases. This is per discussion with @joestringer and @aanm.
gandro
approved these changes
Oct 8, 2020
tgraf
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #13439 & #13439 to 1.8. Depends on #13448.