Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix TLS visibility GSG #13452

Merged
merged 1 commit into from Oct 9, 2020
Merged

docs: Fix TLS visibility GSG #13452

merged 1 commit into from Oct 9, 2020

Conversation

jrajahalme
Copy link
Member

  • Use k8s secret key name ca.crt for ca-certificates.crt so that the example CNP works
  • Change the example monitor output from lyft.com to artii.herokuapp.com
  • Add deletion of the secrets to clean-up
  • Fix indentation and white-spacing in enumerated lists so that they are rendered properly

Signed-off-by: Jarno Rajahalme jarno@covalent.io

- Use k8s secret key name 'ca.crt' for 'ca-certificates.crt' so that the example CNP works
- Change the example monitor output from lyft.com to artii.herokuapp.com
- Add deletion of the secrets to clean-up
- Fix indentation and white-spacing in enumerated lists so that they are rendered properly

Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme jrajahalme added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.7 labels Oct 7, 2020
@jrajahalme jrajahalme requested a review from a team as a code owner October 7, 2020 21:56
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.5 Oct 7, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.7.11 Oct 7, 2020
@joestringer joestringer added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 8, 2020
@aanm aanm merged commit 837caf8 into master Oct 9, 2020
@aanm aanm deleted the pr/jrajahalme/tls-doc-fixes branch October 9, 2020 08:01
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.5 Oct 9, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.7 in 1.7.11 Oct 9, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.7 in 1.7.11 Oct 9, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.11 Oct 13, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.11 Oct 13, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.5 Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.7.11
Backport done to v1.7
1.8.5
Backport done to v1.8
Development

Successfully merging this pull request may close these issues.

None yet

6 participants