Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update arping lib to fix concurrency issues #13482

Merged
merged 1 commit into from Oct 12, 2020

Conversation

aanm
Copy link
Member

@aanm aanm commented Oct 9, 2020

The library was fixed upstream with some concurrency issues that were
found.

Signed-off-by: André Martins andre@cilium.io

Fixes #13435

@aanm aanm added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.8 kind/bug/race-detector labels Oct 9, 2020
@aanm aanm requested a review from a team as a code owner October 9, 2020 10:51
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.5 Oct 9, 2020
@aanm aanm force-pushed the pr/fix-race-detection-13435 branch from f05e0c8 to 698b760 Compare October 9, 2020 10:51
The library was fixed upstream with some concurrency issues that were
found.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/fix-race-detection-13435 branch from 698b760 to abc1c5e Compare October 9, 2020 11:13
@aanm
Copy link
Member Author

aanm commented Oct 9, 2020

test-me-please

@aanm
Copy link
Member Author

aanm commented Oct 9, 2020

retest-gke

3 similar comments
@aanm
Copy link
Member Author

aanm commented Oct 9, 2020

retest-gke

@aanm
Copy link
Member Author

aanm commented Oct 9, 2020

retest-gke

@aanm
Copy link
Member Author

aanm commented Oct 12, 2020

retest-gke

@aanm aanm merged commit 400dfcb into cilium:master Oct 12, 2020
@aanm aanm deleted the pr/fix-race-detection-13435 branch October 12, 2020 13:54
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 12, 2020
@pchaigno
Copy link
Member

The library was fixed upstream with some concurrency issues that were found.

Ah, that explains why I had so much trouble git blaming a Cilium contributor :-)

@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.5 Oct 12, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.5 Oct 12, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.5 Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug/race-detector kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
1.8.5
Backport done to v1.8
Development

Successfully merging this pull request may close these issues.

[RACE Detector]: pkg/datapath/linux.(*linuxNodeHandler).insertNeighbor()
5 participants