hubble/relay: print better error message on peer conn dial failure #13484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To connect to peers via gRPC, Hubble Relay uses `grpc.DialContext()`
with a dial timeout. When a connection attempt to a peer fails, the
following error message is returned: `context deadline exceeded`.
This provides no value when trying to debug the issue. Is the peer
unreachable? Is this a TLS configuration issue? etc.
By using the dial option `grpc.FailOnNonTempDialError(true)`, we get
better error messages on non-temporary dial errors, such as:
connection error: desc = "transport: error while dialing: dial tcp 172.18.0.4:4244: connect: connection refused"
Using the option `grpc.WithReturnConnectionError()`, we would get a
message that contains both the last connection error that occurred and
the `context.DeadlineExceeded` error. This greatly improves the
situation for errors that are deemed transient. Example:
context deadline exceeded: connection error: desc = "transport: authentication handshake failed: x509: certificate is valid for *.hubble-relay.cilium.io, not localhost"
However, this is only available starting with grpc-go v1.30.0 and due to
the issue described here[0], we are currently stuck with v1.29.1. Thus,
this commit adds the option but comments it with a TODO note so that it
can be caught up and uncommented when upgrading grpc-go becomes
possible.
[0]: #13405 (comment)
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
added
kind/cleanup
kaworu
approved these changes
Oct 9, 2020
|
test-me-please |
|
test-gke |
1 similar comment
|
test-gke |
|
retest-4.9 |
glibsm
approved these changes
Oct 9, 2020
|
test-gke |
maintainer-s-little-helper
bot
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.5
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To connect to peers via gRPC, Hubble Relay uses
grpc.DialContext()with a dial timeout. When a connection attempt to a peer fails, the
following error message is returned:
context deadline exceeded.This provides no value when trying to debug the issue. Is the peer
unreachable? Is this a TLS configuration issue? etc.
By using the dial option
grpc.FailOnNonTempDialError(true), we getbetter error messages on non-temporary dial errors, such as:
Using the option
grpc.WithReturnConnectionError(), we would get amessage that contains both the last connection error that occurred and
the
context.DeadlineExceedederror. This greatly improves thesituation for errors that are deemed transient. Example:
However, this is only available starting with grpc-go v1.30.0 and due to
the issue described here, we are currently stuck with v1.29.1. Thus,
this commit adds the option but comments it with a TODO note so that it
can be caught up and uncommented when upgrading grpc-go becomes
possible.