Enable bandwidth-manager by default for new deployments #13535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonnet
added
sig/datapath
This was referenced Oct 13, 2020
qmonnet
force-pushed
the
pr/qmonnet/edt_reenable_newdeplmts
branch
2 times, most recently
from
f61211d
to
b0e4123
Compare
|
test-me-please |
christarazi
approved these changes
Oct 15, 2020
sayboras
approved these changes
Oct 15, 2020
kkourt
approved these changes
Oct 15, 2020
qmonnet
added
the
dont-merge/needs-rebase
aanm
removed
the
dont-merge/wait-until-release
qmonnet
force-pushed
the
pr/qmonnet/edt_reenable_newdeplmts
branch
from
b0e4123
to
06de7f5
Compare
qmonnet
removed
the
dont-merge/needs-rebase
|
test-me-please |
qmonnet
changed the title
christarazi
approved these changes
Nov 11, 2020
|
test-me-please |
Bandwidth manager was a beta feature in Cilium 1.9, and as such we disabled it by default for new deployments. For newer versions, enable bandwidth manager by default. This reverts commit a0ad5ad. Signed-off-by: Quentin Monnet <quentin@isovalent.com>
Add a comment to implement the TODO and provide some documentation for the "bandwidthManager" value in the yaml file. Signed-off-by: Quentin Monnet <quentin@isovalent.com>
qmonnet
force-pushed
the
pr/qmonnet/edt_reenable_newdeplmts
branch
from
06de7f5
to
b0635ce
Compare
|
test-me-please |
christarazi
approved these changes
Nov 16, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Cilium v1.10, bandwidth manager is no longer considered as a beta feature: re-enable it by default for new deployments.
This PR reverts the commit that disabled the feature by default, but it does not update the documentation that still marks the bandwidth manager as beta.
Reverts part of #13515.
Also related: Follow-ups for EDT #13371.