v1.8 backports 2020-10-19 #13628
Merged
v1.8 backports 2020-10-19 #13628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolinh
added
kind/backports
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
rolinh
removed
the
dont-merge/needs-release-note-label
christarazi
approved these changes
Oct 19, 2020
nathanjsweet
approved these changes
Oct 19, 2020
|
test-backport-1.8 |
|
retest-4.19 |
aanm
approved these changes
Oct 20, 2020
kkourt
approved these changes
Oct 20, 2020
[ upstream commit ee7e681 ] Renamed the scripts repo to `cilium-perf-networking.git` to make it more clear and less annoying for people that have to check it out. While we are at it, add a note about the terraform version that we expect. Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com> Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
[ upstream commit 2e0539a ] When running Cilium with the devices set, but neither kube-proxy-free or the host firewall enabled, cilium-agent will attempt to remove the previous BPF program from the native devices' egress tc hook. If no program is attached there (i.e., Cilium was running without host firewall and kube-proxy replacement before restarting), the removal will fail with the following error. level=error msg="Command execution failed" cmd="[tc filter delete dev enp0s8 egress]" error="exit status 2" subsys=datapath-loader level=warning msg="Error: Parent Qdisc doesn't exists." subsys=datapath-loader level=warning msg="We have an error talking to the kernel, -1" subsys=datapath-loader This commit fixes this error by first checking that the device has a BPF program attached on egress. I tested this in the dev. VM, by first starting Cilium with our kube-proxy-replacement, then without but keeping the devices configuration. Fixes: a695f53 ("Endpoint for host") Signed-off-by: Paul Chaignon <paul@cilium.io> Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
force-pushed
the
pr/v1.8-backport-2020-10-19
branch
from
f726fed
to
5d4741e
Compare
|
test-backport-1.8 |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipped due to conflicts:
EDIT: I removed the following PR as it was found (thanks @aanm) that it introduces a regression that leads to a deadlock situation when some endpoints are being deleted on restore. cc @christarazi
Once this PR is merged, you can update the PR labels via: