Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.8 backport 2020-10-20 #13657

Merged
merged 4 commits into from
Oct 22, 2020
Merged

v1.8 backport 2020-10-20 #13657

merged 4 commits into from
Oct 22, 2020

Conversation

nathanjsweet
Copy link
Member

v1.8 backports 2020-10-20

Once this PR is merged, you can update the PR labels via:

$ for pr in 13299 13295 13640; do contrib/backporting/set-labels.py $pr done 1.8; done

konghui and others added 4 commits October 20, 2020 20:00
@konghui @nathanjsweet
add error log When ipam allocate nodecidr failure
e61e927 
[ upstream commit ef6ecbd ]

Signed-off-by: hui.kong <konghui@live.cn>
Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
@pchaigno @nathanjsweet
test: Display BPF map content on fail
70660af 
[ upstream commit ec2c18a ]

Signed-off-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
@brb @nathanjsweet
docs: Add note about src/dst IP check on cloud for DSR
ea1bde4 
[ upstream commit ad6cffe ]

Signed-off-by: Martynas Pumputis <m@lambda.lt>
Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
@brb @nathanjsweet
docs: Mention about no ClusterIP access from outside cluster
fe06c9a 
[ upstream commit 6e85cb4 ]

The k8s Service "spec" disallows accessing ClusterIP services from
outside a cluster.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
@nathanjsweet nathanjsweet requested a review from a team as a code owner October 21, 2020 01:02
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.8 kind/backports This PR provides functionality previously merged into master. labels Oct 21, 2020
@nathanjsweet nathanjsweet changed the title Pr/v1.8 backport 2020 10 20 v1.8 backport 2020-10-20 Oct 21, 2020
@nathanjsweet
Copy link
Member Author

test-backport-1-8

@joestringer
Copy link
Member

test-backport-1.8

pchaigno
pchaigno approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My changes look good 👍

brb
brb approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for my changes, thanks.

@nathanjsweet
Copy link
Member Author

retest-4.19

@joestringer
Copy link
Member

Hit #6728

@joestringer joestringer merged commit c2442da into v1.8 Oct 22, 2020
@joestringer joestringer deleted the pr/v1.8-backport-2020-10-20 branch October 22, 2020 02:02
@pchaigno
Copy link
Member

@nathanjsweet It looks like the backported PRs never had their labels switched to backport-pending/1.8 then backport-done/1.8. You might want to use the script to automate that and investigate/report any error/warning you get while doing so.

@joestringer #12346 (comment) 😜

@christarazi christarazi mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

@pchaigno pchaigno pchaigno approved these changes

Assignees
No one assigned
Labels
kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nathanjsweet @joestringer @pchaigno @brb @konghui