Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve debugging of dns issues, add retries to external conn check #13694

Merged
merged 2 commits into from
Oct 23, 2020
Merged

test: improve debugging of dns issues, add retries to external conn check #13694

merged 2 commits into from
Oct 23, 2020

Conversation

nebril
Copy link
Member

@nebril nebril commented Oct 22, 2020

No description provided.

@nebril
test: add curl retries to testPodHTTPToOutside
6d7e13d 
This function can suffer from connectivity loss between cluster and
external IP, which is not dependant on Cilium. These retries will help
reduce flakiness.

Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril nebril requested a review from a team as a code owner October 22, 2020 09:38
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 22, 2020
@nebril nebril added the ci/fail-fast This label makes a CI build fail immediately if any test across all test suites fails. label Oct 22, 2020
@nebril
Copy link
Member Author

nebril commented Oct 22, 2020

test-missed-k8s

@nebril nebril added the release-note/ci This PR makes changes to the CI. label Oct 22, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 22, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.0-rc3 Oct 22, 2020
pchaigno
pchaigno reviewed Oct 22, 2020
View reviewed changes
test/helpers/kubectl.go Show resolved Hide resolved
test/helpers/kubectl.go Outdated Show resolved Hide resolved
test/helpers/kubectl.go Outdated Show resolved Hide resolved
@nebril
test: don't pipe dig into grep to get full output
70efcaf 
Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril nebril force-pushed the pr/debug-dns-issues-with-datapath branch from 1d6801c to 70efcaf Compare October 22, 2020 16:16
@nebril nebril requested a review from brb October 22, 2020 16:17
@nebril
Copy link
Member Author

nebril commented Oct 22, 2020

test-me-please

@nebril
Copy link
Member Author

nebril commented Oct 22, 2020

k8s-all build from initial PR passed, next PR revision deleted two comments, no other changes were made, so after CI passes successfully we can merge this

@nebril
Copy link
Member Author

nebril commented Oct 22, 2020

test-4.19

@joestringer joestringer mentioned this pull request Oct 22, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 23, 2020
@nebril nebril merged commit c1af153 into master Oct 23, 2020
@nebril nebril deleted the pr/debug-dns-issues-with-datapath branch October 23, 2020 06:59
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.5 Oct 23, 2020
@pchaigno pchaigno mentioned this pull request Oct 23, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.5 Oct 23, 2020
@gandro gandro mentioned this pull request Oct 23, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.0-rc3 Oct 23, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.0-rc3 Oct 23, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.0-rc3 Oct 23, 2020
@christarazi christarazi mentioned this pull request Oct 28, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.5 Oct 31, 2020
@joestringer joestringer mentioned this pull request Nov 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

@pchaigno pchaigno pchaigno approved these changes

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
ci/fail-fast This label makes a CI build fail immediately if any test across all test suites fails. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.8.5
Backport done to v1.8
1.9.0-rc3
Backport done to v1.9
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nebril @brb @pchaigno @christarazi @gandro @joestringer @aanm