fqdn: Optimize KeepUniqueNames #13920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
added
kind/enhancement
Not sure if this is of any actual significance, but KeepUniqueNames() is called from couple of places. Modify it to filter out duplicates in place so that no memory allocations are needed. Using naive search for duplicates instead of a map is about 5x faster for small sets of names. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
force-pushed
the
pr/jrajahalme/fqdn-keep-unique-names
branch
from
39a647d
to
4d2c760
Compare
|
test-me-please |
aanm
added
dont-merge/wait-until-release
|
test-gke |
|
retest-runtime |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is of any actual significance, but KeepUniqueNames()
is called from couple of places. Modify it to filter out duplicates in
place so that no memory allocations are needed.
Using naive search for duplicates instead of a map is about 5x faster
for small sets of names.
Signed-off-by: Jarno Rajahalme jarno@covalent.io