Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cilium/cmd: mark tests as unprivileged #13933

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Nov 6, 2020

Commit 4eb58b8 ("cmd: mark tests as privileged") marked these as
privileged, but the BPF functionality no longer seems to be imported by
these tests so they run just fine as unprivileged tests.

Commit 4eb58b8 ("cmd: mark tests as privileged") marked these as
privileged, but the BPF functionality no longer seems to be imported by
these tests so they run just fine as unprivileged tests.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser added area/cli Impacts the command line interface of any command in the repository. release-note/misc This PR makes changes that have no direct user impact. labels Nov 6, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Nov 6, 2020
@tklauser
Copy link
Member Author

tklauser commented Nov 6, 2020

Travis CI (which runs all unprivileged tests) passed. Running Jenkins CI not necessary.

@tklauser tklauser marked this pull request as ready for review November 6, 2020 15:18
@tklauser tklauser requested a review from a team as a code owner November 6, 2020 15:18
@tklauser tklauser requested a review from twpayne November 6, 2020 15:18
@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 6, 2020
@jrfastab
Copy link
Contributor

jrfastab commented Nov 6, 2020

test-me-please

@aanm aanm merged commit 1a0bd24 into master Nov 9, 2020
@aanm aanm deleted the pr/tklauser/cli-unprivileged-tests branch November 9, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Impacts the command line interface of any command in the repository. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants