Makefile: Simplify to run faster #13939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid using grep options that are not supported on macOS. This
eliminates errors like this:
grep: repetition-operator operand invalid
expr: syntax error
usage: grep [-abcDEFGHhIiJLlmnOoqRSsUVvwxZ] [-A num] [-B num] [-C[num]]
[-e pattern] [-f file] [--binary-files=value] [--color=when]
[--context[=num]] [--directories=action] [--label] [--line-buffered]
[--null] [pattern] [file ...]
Make 'go list' faster by adding '-find' option that eliminates
resolution of some state we are not using:
"The -find flag causes list to identify the named packages but not
resolve their dependencies: the Imports and Deps lists will be empty."
This makes 'make nothing' to run about twice as fast as before,
especially in the dev VM.
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
added
release-note/minor
|
test-me-please |
aanm
approved these changes
Nov 9, 2020
aanm
added
release-note/misc
|
Thank you for this! There are at least a couple of other scripts that use https://github.com/cilium/cilium/blob/master/contrib/scripts/check-assert-deep-equals.sh#L10 https://github.com/cilium/cilium/blob/master/contrib/scripts/check-logging-subsys-field.sh#L20-L22 Would you be able to address these too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using grep options that are not supported on macOS. This
eliminates errors like this:
Make 'go list' faster by adding '-find' option that eliminates
resolution of some state we are not using:
This makes 'make nothing' to run about twice as fast as before,
especially in the dev VM.
Signed-off-by: Jarno Rajahalme jarno@covalent.io