Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.7 backports 2020-11-09 #13950

Merged
merged 4 commits into from Nov 10, 2020
Merged

v1.7 backports 2020-11-09 #13950

merged 4 commits into from Nov 10, 2020

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Nov 9, 2020

Once this PR is merged, you can update the PR labels via:

$ for pr in 13892 13907 13886 13914; do contrib/backporting/set-labels.py $pr done 1.7; done

aanm and others added 4 commits November 9, 2020 13:51
[ upstream commit 73be2c1 ]

To check if images are published across all repositories the
`check-docker-images.sh` script will be able to perform this check of a
particular release.

Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
[ upstream commit 86e419e ]

In cluster that have some high churn of pods being created and deleted
with different security identities, garbage collecting 250 identities
per minute might not be sufficient. Thus, we are increasing the default
limit to 2500 identities per minute.

Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
[ upstream commit af95561 ]

The security id lookup could return nil if the identity cache
isn't initialized during endpoints restore time, resulting in a crash.
Hence, add a nil check before populating log record values.

Signed-off-by: Aditi Ghag <aditi@cilium.io>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
[ upstream commit 5923daf ]

There are applications that when a DNS name resolves to multiple IPs,
they will store the IPs and use them past their TTL point.

For example:
 - name resolves to IP1,IP2
 - app connects to IP1
 - protocol error forces disconnect
 - app connects to IP2

This patch keeps the IPs that map to a name alive as long as one of the
IPs for the given name is alive, so that applications like the one above
will not fail.

Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser requested a review from a team as a code owner November 9, 2020 12:59
@tklauser tklauser requested review from jrfastab and removed request for a team November 9, 2020 12:59
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.7 kind/backports This PR provides functionality previously merged into master. labels Nov 9, 2020
@tklauser tklauser added backport/1.7 kind/backports This PR provides functionality previously merged into master. labels Nov 9, 2020
@tklauser
Copy link
Member Author

tklauser commented Nov 9, 2020

test-backport-1.7

previous failure: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-K8s/3678/, opened #13954

@tklauser
Copy link
Member Author

tklauser commented Nov 9, 2020

test-missed-k8s

previous failure: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-K8s/3682/ #13552

Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My change looks good.

Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my patch

@tklauser
Copy link
Member Author

tklauser commented Nov 9, 2020

test-missed-k8s

Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for my changes

@aanm aanm merged commit a968618 into v1.7 Nov 10, 2020
@aanm aanm deleted the pr/v1.7-backport-2020-11-09 branch November 10, 2020 08:25
Comment on lines +45 to +54
$(QUIET)\
HUBBLE_PROXY_VERSION=$(HUBBLE_PROXY_VERSION) \
HUBBLE_UI_VERSION=$(HUBBLE_UI_VERSION) \
MANAGED_ETCD_VERSION=$(MANAGED_ETCD_VERSION) \
ETCD_VERSION=$(ETCD_VERSION) \
NODEINIT_VERSION=$(NODEINIT_VERSION) \
CERTGEN_VERSION=`echo $(CERTGEN_VERSION) | egrep -o '^.*@' | sed 's/@//'` \
../../contrib/release/check-docker-images.sh "v$(VERSION)"

.phony: all check-docker-images clean update-versions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the same as #13892, the target is missing and half of the versions don't make sense for the v1.7 tree where there was no hubble ui, certgen, hubble proxy, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants