Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: update security releases #13977

Merged
merged 1 commit into from
Nov 10, 2020
Merged

README: update security releases #13977

merged 1 commit into from
Nov 10, 2020

Conversation

aanm
Copy link
Member

@aanm aanm commented Nov 10, 2020

Signed-off-by: André Martins andre@cilium.io

@aanm aanm requested a review from a team as a code owner November 10, 2020 17:03
@aanm aanm requested a review from rolinh November 10, 2020 17:03
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 10, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Nov 10, 2020
@rolinh rolinh added the release-note/misc This PR makes changes that have no direct user impact. label Nov 10, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 10, 2020
rolinh
rolinh requested changes Nov 10, 2020
View reviewed changes
Copy link
Member

@rolinh rolinh left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think versions should be bumped in SECURITY.md as well.

@aanm aanm requested a review from rolinh November 10, 2020 17:11
@aanm aanm requested a review from a team as a code owner November 10, 2020 17:11
@aanm aanm requested a review from fristonio November 10, 2020 17:11
@aanm
Copy link
Member Author

aanm commented Nov 10, 2020

I think versions should be bumped in SECURITY.md as well.

It's the first time I'm seeing this file :D

fristonio
fristonio approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@fristonio fristonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🚀

@maintainer-s-little-helper
Copy link

Commit 9768ffae5d52c85c9903d6752eb12ed987d72dbd does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Nov 10, 2020
@joestringer
Copy link
Member

Github UI messed up when I tried to merge, will fix in a moment.

@aanm @joestringer
README: update security releases
ec3f173 
Signed-off-by: André Martins <andre@cilium.io>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Nov 10, 2020
@joestringer joestringer merged commit a02744c into cilium:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolinh rolinh rolinh approved these changes

@fristonio fristonio fristonio approved these changes

Assignees

@rolinh rolinh

@fristonio fristonio

Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanm @joestringer @rolinh @fristonio