test/k8sT/manifests: use image hash with cilium-builder image #13982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
area/CI
tklauser
force-pushed
the
pr/tklauser/test-k8s-verifier-builder-image-hash
branch
from
de4061a
to
905df9e
Compare
|
test-me-please failed due to docker registry rate limiting 😞 |
|
retest-net-next |
|
retest-4.9 |
|
retest-4.19 |
|
retest-gke |
christarazi
approved these changes
Nov 11, 2020
Will fix up once all tests passed and this is ready to be merged. |
|
retest-4.19 previous failure: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Kernel/3778/, looks like #13552 |
nebril
approved these changes
Nov 12, 2020
aanm
approved these changes
Nov 12, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
Tags can be arbitrarily changed without the user noticing, potentially making the tag point to a completely different image. Instead, reference the cilium-builder image by its unique sha256 hash which is already done in all other places using the image. While at it, also bump the image to the latest version which was bumped to Go 1.15.4 in #13945. Fixes: 417cded ("test: Move RuntimeVerifier to K8sVerifier") Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
force-pushed
the
pr/tklauser/test-k8s-verifier-builder-image-hash
branch
from
905df9e
to
f2eb0eb
Compare
|
Test have previously passed, force pushed to fix the typo in the commit message pointed out by @christarazi: #13982 (review) |
christarazi
deleted the
pr/tklauser/test-k8s-verifier-builder-image-hash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tags can be arbitrarily changed without the user noticing, potentially
making the tag point to a completely different image. Instead, reference
the cilium-builder image by its unique sha256 hash which is already done
in all other places using the image.
While at it, also bump the image to the latest version which was bumped
to Go 1.15.4 in #13945.
Fixes: 417cded ("test: Move RuntimeVerifier to K8sVerifier")
Note that the manifests in the
v1.8andv1.9release branches already use the image hash.