fqdn: Make maximum number of IPs per restored rule configurable #13992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
added
kind/bug
Only count the number of IPs for each FQDN selector/rule when storing rules for restoration, rather than ignoring later rules on a port after previous rules have hit the maximum number of IPs. Make the maximum number of IPs per restored rule configurable with the new option '--tofqdns-max-ips-per-restored-rule' (default 1000). Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
force-pushed
the
pr/jrajahalme/fwdn-make-restore-IP-limit-configurable
branch
from
af3944f
to
4f364ea
Compare
|
test-me-please |
christarazi
approved these changes
Nov 12, 2020
| @@ -193,7 +193,7 @@ func (s *DNSProxyTestSuite) SetUpTest(c *C) { | |||
| s.dnsServer = setupServer(c) | |||
| c.Assert(s.dnsServer, Not(IsNil), Commentf("unable to setup DNS server")) | |||
|
|
|||
| proxy, err := StartDNSProxy("", 0, true, // any address, any port, enable compression | |||
| proxy, err := StartDNSProxy("", 0, true, 1000, // any address, any port, enable compression, max 1000 restore IPs | |||
There was a problem hiding this comment.
Might make sense to use the new default here instead of hardcoding 1000.
|
v1.7 backport in #13993 |
maintainer-s-little-helper
bot
added
the
ready-to-merge
aanm
deleted the
pr/jrajahalme/fwdn-make-restore-IP-limit-configurable
branch
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.12
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Needs backport from master
in 1.7.12
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.6
kaworu
pushed a commit
that referenced
this pull request
Nov 19, 2020
[ upstream commit a218052 ] Restored DNS proxy rules are DNS rules, not ToFQDNs rules. Fixes: #13991 Fixes: #13992 v1.8 backport: fixed conflict on Documentation/cmdref/cilium-agent.md and pkg/option/config.go:2461 Signed-off-by: Jarno Rajahalme <jarno@covalent.io> Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.12
kaworu
pushed a commit
that referenced
this pull request
Nov 26, 2020
[ upstream commit a218052 ] Restored DNS proxy rules are DNS rules, not ToFQDNs rules. Fixes: #13991 Fixes: #13992 v1.8 backport: fixed conflict on Documentation/cmdref/cilium-agent.md and pkg/option/config.go:2461 Signed-off-by: Jarno Rajahalme <jarno@covalent.io> Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
aanm
pushed a commit
that referenced
this pull request
Nov 30, 2020
[ upstream commit a218052 ] Restored DNS proxy rules are DNS rules, not ToFQDNs rules. Fixes: #13991 Fixes: #13992 v1.8 backport: fixed conflict on Documentation/cmdref/cilium-agent.md and pkg/option/config.go:2461 Signed-off-by: Jarno Rajahalme <jarno@covalent.io> Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
This was referenced Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only count the number of IPs for each FQDN selector/rule when storing
rules for restoration, rather than ignoring later rules on a port
after previous rules have hit the maximum number of IPs.
Make the maximum number of IPs per restored rule configurable with the
new option
--tofqdns-max-ips-per-restored-rule(default 1000).Signed-off-by: Jarno Rajahalme jarno@covalent.io