Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Move RuntimeCLI to K8sCLI #14017

Merged
merged 1 commit into from
Nov 17, 2020
Merged

test: Move RuntimeCLI to K8sCLI #14017

merged 1 commit into from
Nov 17, 2020

Conversation

pchaigno
Copy link
Member

Updates: #12258

@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ci/flake This is a known failure that occurs in the tree. Please investigate me! labels Nov 13, 2020
@pchaigno pchaigno requested a review from a team as a code owner November 13, 2020 11:29
@pchaigno pchaigno requested a review from nebril November 13, 2020 11:29
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 13, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Nov 13, 2020
@pchaigno pchaigno added the release-note/ci This PR makes changes to the CI. label Nov 13, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 13, 2020
@pchaigno pchaigno mentioned this pull request Nov 13, 2020
Closed
@pchaigno pchaigno force-pushed the pr/pchaigno/move-runtimecli-k8scli branch from d03c97b to c70fd03 Compare November 13, 2020 11:33
aanm
aanm requested changes Nov 13, 2020
View reviewed changes
test/k8sT/manifests/test-cli.yaml Outdated Show resolved Hide resolved
test/k8sT/manifests/test-cli.yaml Outdated Show resolved Hide resolved
test/k8sT/manifests/test-cli.yaml Outdated Show resolved Hide resolved
@pchaigno pchaigno force-pushed the pr/pchaigno/move-runtimecli-k8scli branch from c70fd03 to 18a2420 Compare November 13, 2020 13:54
@pchaigno pchaigno requested a review from aanm November 13, 2020 13:55
@pchaigno
Copy link
Member Author

⚠️ Note I've restricted that test to run only on our GKE pipeline.

@pchaigno pchaigno force-pushed the pr/pchaigno/move-runtimecli-k8scli branch 2 times, most recently from 8aab2ea to 44cb424 Compare November 13, 2020 17:24
christarazi
christarazi approved these changes Nov 14, 2020
View reviewed changes
test/k8sT/cli.go Outdated Show resolved Hide resolved
@pchaigno
test: Move RuntimeCLI to K8sCLI
4713ed1 
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno force-pushed the pr/pchaigno/move-runtimecli-k8scli branch from 44cb424 to 4713ed1 Compare November 14, 2020 11:38
@aanm aanm removed their assignment Nov 16, 2020
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 16, 2020
@aanm aanm merged commit 96c234e into master Nov 17, 2020
@aanm aanm deleted the pr/pchaigno/move-runtimecli-k8scli branch November 17, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril approved these changes

@christarazi christarazi christarazi approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ci/flake This is a known failure that occurs in the tree. Please investigate me! ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pchaigno @nebril @christarazi @aanm