helm/hubble-ui: fixed ingress configuration on EKS clusters #14023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes cilium#14018 Signed-off-by: Maxime VISONNEAU <maxime.visonneau@gmail.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
qmonnet
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
errordeveloper
approved these changes
Nov 13, 2020
errordeveloper
added
the
ready-to-merge
kaworu
approved these changes
Nov 13, 2020
|
Nominate for backport 1.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On EKS clusters, the interpolated value of
.Capabilities.KubeVersion.Versionis assimilated as a prerelease per its semver syntax, eg:v1.18.8-eks-7c9bda. With this change, we are fixing the compute of theingress.apiVersiontemplate parameter when deploying over EKS clusters.Fixes: #14018