Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor backporting script tweaks #14027

Merged
merged 2 commits into from
Nov 16, 2020
Merged

Minor backporting script tweaks #14027

merged 2 commits into from
Nov 16, 2020

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented Nov 13, 2020

Just a couple of things to make life easier for backporters :)

@twpayne twpayne added release-note/misc This PR makes changes that have no direct user impact. area/build Anything to do with the build, more general then area/CI labels Nov 13, 2020
@twpayne twpayne requested review from a team as code owners November 13, 2020 16:06
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Nov 13, 2020
@twpayne
dev-doctor: Add hub binary check
730a887 
Signed-off-by: Tom Payne <tom@isovalent.com>
@twpayne
backporting: Stop scripts from running on non-Linux
2adc907 
This is mainly for the benefit of macOS users typing in the wrong
terminal.

Signed-off-by: Tom Payne <tom@isovalent.com>
@twpayne twpayne force-pushed the pr/twpayne/backporting-tweaks branch from 13120f9 to 2adc907 Compare November 15, 2020 01:12
@tklauser tklauser removed their assignment Nov 16, 2020
@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 16, 2020
fristonio
fristonio approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@fristonio fristonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fristonio fristonio merged commit 05eabc7 into master Nov 16, 2020
@fristonio fristonio deleted the pr/twpayne/backporting-tweaks branch November 16, 2020 11:58
@gandro
Copy link
Member

gandro commented Feb 22, 2021

Marking this for backport, because submit-backport is executed from the backport branches.

Note to backporters: You only need to backport commit 05eabc7 - tools/dev-doctor is not available on older branches.

This was referenced Feb 22, 2021
Merged
Merged
@gandro gandro mentioned this pull request Feb 22, 2021
Merged
@joestringer joestringer mentioned this pull request Feb 25, 2021
Merged
@christarazi christarazi mentioned this pull request Mar 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@pchaigno pchaigno pchaigno approved these changes

@christarazi christarazi christarazi approved these changes

@fristonio fristonio fristonio approved these changes

@jrajahalme jrajahalme Awaiting requested review from jrajahalme

Assignees

@christarazi christarazi

@jrajahalme jrajahalme

Labels
area/build Anything to do with the build, more general then area/CI ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@twpayne @gandro @tklauser @pchaigno @christarazi @fristonio @jrajahalme @qmonnet