Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cilium: Use strings, not byte slices, for JSON dumps #14041

Merged
merged 1 commit into from
Nov 17, 2020
Merged

cilium: Use strings, not byte slices, for JSON dumps #14041

merged 1 commit into from
Nov 17, 2020

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented Nov 16, 2020

@twpayne twpayne added area/cli Impacts the command line interface of any command in the repository. release-note/misc This PR makes changes that have no direct user impact. labels Nov 16, 2020
@twpayne twpayne requested review from a team as code owners November 16, 2020 12:16
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Nov 16, 2020
@twpayne twpayne mentioned this pull request Nov 16, 2020
Merged
tklauser
tklauser approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

fristonio
fristonio approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@fristonio fristonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@twpayne twpayne added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 16, 2020
@kaworu kaworu removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 16, 2020
@twpayne
Copy link
Contributor Author

twpayne commented Nov 16, 2020

test-me-please

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 16, 2020
@fristonio fristonio merged commit 19c1818 into master Nov 17, 2020
@fristonio fristonio deleted the pr/twpayne/dump-json-to-string branch November 17, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@aanm aanm aanm approved these changes

@fristonio fristonio fristonio approved these changes

Assignees

@tklauser tklauser

@fristonio fristonio

Labels
area/cli Impacts the command line interface of any command in the repository. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@twpayne @tklauser @aanm @fristonio @kaworu