Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/hubble-internals: update Hubble Relay section to reflect current state #14042

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Nov 16, 2020

Hubble Relay is no more in-progress and is declared stable with the
release of Cilium v1.9 thus remove the "work in progress" note
Also update the Hubble internals doc section for Hubble Relay and
complete the section with technical information.
While here, fix a few typos in the whole doc section.

@rolinh rolinh added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay needs-backport/1.9 labels Nov 16, 2020
@rolinh rolinh requested review from a team and gandro November 16, 2020 13:25
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Nov 16, 2020
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Hubble Relay is no more in-progress and is declared stable with the
release of Cilium v1.9 thus remove the "work in progress" note
Also update the Hubble internals doc section for Hubble Relay and
complete the section with technical information.
While here, fix a few typos in the whole doc section.

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh force-pushed the pr/rolinh/doc-hubble-internals-update branch from d51b84d to 475813d Compare November 16, 2020 13:37
@rolinh rolinh added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 16, 2020
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Documentation/hubble.rst Show resolved Hide resolved
Copy link
Contributor

@twpayne twpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

@fristonio
Copy link
Member

Does not need a full CI run. Merging! 🎉

@fristonio fristonio merged commit 7dc5a57 into master Nov 17, 2020
@fristonio fristonio deleted the pr/rolinh/doc-hubble-internals-update branch November 17, 2020 10:25
@joestringer joestringer added this to Backport pending to v1.9 in 1.9.1 Nov 17, 2020
@aanm aanm mentioned this pull request Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay
Projects
No open projects
1.9.1
Backport pending to v1.9
Development

Successfully merging this pull request may close these issues.

None yet

6 participants