ipvlan: use github.com/cilium/ebpf to create map and load program #14043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
sig/datapath
|
test-me-please |
tklauser
force-pushed
the
pr/tklauser/ipvlan-ebpf-lib
branch
from
a520718
to
f8f1b72
Compare
|
test-me-please |
tklauser
force-pushed
the
pr/tklauser/ipvlan-ebpf-lib
branch
from
f8f1b72
to
d84adeb
Compare
This will also pull in github.com/google/go-cmp v0.5.2 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
This commit introduces a test to verify the tail call map program is unchanged during refactoring by successive commits. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
This makes it easier to understand what the eBPF program does. In commit 7bfe015 ("cilium, ipvlan: add initial endpoint ipvlan support") the loaded program was described as: [...] The program we load to cls_bpf is doing: load BPF map fd into register R2, load 0 into register R3, (R1 has implicit skb already), and do a tail call into the map. Fall-through is just exiting with TC_ACT_OK. [...] Using TestEntryProgInstructions introduced in the previous commit it can be verified that the emitted instructions are in fact the same. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
This allows to drop the local copy of bpfAttrProg and the magic numbers for prog type and the bpf() syscall commands. Instead it leverages the cilium ebpf lib to load the eBPF program. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Use the github.com/cilium/ebpf library to create the tail call map and load the corresponding program. This allows to drop local definitions of various BPF types as well as a lot of direct interaction with the bpf() syscall. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
force-pushed
the
pr/tklauser/ipvlan-ebpf-lib
branch
from
d84adeb
to
dcfe087
Compare
|
Rebased after #14056 was merged. |
|
test-me-please |
jibi
approved these changes
Nov 18, 2020
nathanjsweet
approved these changes
Nov 18, 2020
|
QQ, what kind of validation have we done on this? When I grep for |
I was wrongly assuming that this is covered by the docker-based runtime tests, sorry about that. I'll run the IPVLAN-based Networking GSG to verify this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewable by commit, see individual commit messages for details.