Centralize building of the aws.Config object #14048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit 9772f8519b5b99107f2403f43c09a08ecde47b72 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
dont-merge/needs-sign-off
ungureanuvladvictor
force-pushed
the
vladu/centrlaize-aws-config
branch
from
9772f85
to
65b5aef
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
ungureanuvladvictor
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
ungureanuvladvictor
added
area/eni
|
test-me-please |
christarazi
approved these changes
Nov 16, 2020
When running the ENI IPAM an operator does not need to pass any region env var flag for the AWS SDK to configure it's client because we read it from the ec2 metadata endpoint. If the same operator wants to run with --update-ec2-apdater-limit-via-api=true then the cilium-operator will fail to construct the ec2 client because a valid region was not passed. Signed-off-by: Vlad Ungureanu <vladu@palantir.com>
ungureanuvladvictor
force-pushed
the
vladu/centrlaize-aws-config
branch
from
65b5aef
to
1180663
Compare
|
test-me-please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the ENI IPAM an operator does not need to pass any region env var flag for the AWS SDK to configure it's client because we read it from the ec2 metadata endpoint. If the same operator wants to run with
--update-ec2-apdater-limit-via-api=truethen thecilium-operatorwill fail to construct the ec2 client because a valid region was not passed.I removed the logging that was identifying that we connected to the ec2 metadata (mostly because we do not have a logger in the package where I moved this). Happy to add it back and construct a logger there but did not think it provides a lot of value IMO.
I think in the future we should use the
ec2.NewClientmethod to get the client for the ENI limits updater so we get bought into the same metrics + QPS pipeline as well.