docs: Fix wording around labels configuration #14064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParseLabelPrefixCfg() appends the user-specified list to the user-specified file for labels. By default, the file is empty, which readLabelPrefixCfgFrom() interprets as "use the default list". This means that by default, when the user specifies a set of labels, it will append to the default list rather than replacing it. Reported-by: Arthur Chiao <arthurchiao@hotmail.com> Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
added
release-note/misc
aanm
approved these changes
Nov 17, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.6
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.6
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.6
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParseLabelPrefixCfg()appends the user-specified list to the user-specified file for labels. By default, the file is empty, whichreadLabelPrefixCfgFrom()interprets as "use the default list". This means that by default, when the user specifies a set of labels, it will append to the default list rather than replacing it./cc @ArthurChiao